chore: add additional network telemetry stats & events #13800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
commented
Jul 8, 2024
| server.telemetryStore.setNetInfo(ni) | ||
| nodeUp.setNetInfo(ni) | ||
| }) | ||
| server.wireguardEngine.AddNetworkMapCallback(func(nm *netmap.NetworkMap) { |
There was a problem hiding this comment.
We use this callback to ensure we always have the latest Tailscale node data for a given peer.
deansheather
reviewed
Jul 9, 2024
deansheather
approved these changes
Jul 9, 2024
ethanndickson
commented
Jul 9, 2024
|
|
||
| // Watch for changes in the connection type (P2P<->DERP) and send telemetry events. | ||
| func (c *Conn) watchConnChange() { | ||
| ticker := time.NewTicker(time.Millisecond * 50) |
There was a problem hiding this comment.
Because we have to manually check if the connection has changed like this, P2PSetup can be ~50ms off it's true value.
ethanndickson
commented
Jul 9, 2024
|
|
||
| // nil if not connected | ||
| connSetupTime *durationpb.Duration | ||
| connectedIP *netip.Addr |
There was a problem hiding this comment.
To support coderd and agent telemetry in the future, we'll need to change this to a map of peers to nodes/IPs.
deansheather
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionAgeto the time sincetailnet.NewConnwas called.ConnectionSetupto the time betweentailnet.NewConnbeing called, and a connected telemetry event being sent.P2PSetupto the time betweentailnet.NewConnand when we find out our connection is direct.