-
Notifications
You must be signed in to change notification settings - Fork 926
feat: add members settings page for organizations #13817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good! Just missing tests for the feature.
QA results:
|
the way we've budgeted it, I'm gonna work on tests towards the end of the next sprint to make sure we don't have to slip the deadline. |
Not a high priority but it seems like it would be simpler to not show users already in the organization in the add user dropdown. |
that's not practically possible right now. some orgs will have thousands of members, and it would require a new backend endpoint that could return only users which are not in that set. if we did the filtering on the client side, you could easily end up in a situation where the first 25 users that we query are all in the org, and we'd have to send another request....and another....and another. if we ever do this, it'll have to be later. it'd be a lot of work to get right, and low reward imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from tests which can be added later, lgtm
No description provided.