Skip to content

feat(cli): show information about --wait=no for ssh #13847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat(cli): show information about --wait=no for ssh #13847

merged 2 commits into from
Jul 9, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jul 9, 2024 •
edited
Loading

Fixes #11923

==> ⧗ Running workspace agent startup scripts
==> ℹ︎ To connect immediately, reconnect with --wait=no or CODER_SSH_WAIT=no, see --help for more information.
2024-07-09 12:04:55.983+03:00 Startup Script: 1
2024-07-09 12:04:56.963+03:00 Startup Script: 2
2024-07-09 12:04:57.965+03:00 Startup Script: 3
2024-07-09 12:04:58.966+03:00 Startup Script: 4
2024-07-09 12:04:59.967+03:00 Startup Script: 5
2024-07-09 12:05:00.968+03:00 Startup Script: 6
2024-07-09 12:05:01.969+03:00 Startup Script: 7
2024-07-09 12:05:02.971+03:00 Startup Script: 8
2024-07-09 12:05:03.972+03:00 Startup Script: 9
2024-07-09 12:05:04.973+03:00 Startup Script: 10
2024-07-09 12:05:05.988+03:00 Startup Script: Checking if dotfiles repository already exists...
2024-07-09 12:05:05.988+03:00 Startup Script: Found dotfiles repository at /home/mafredri/.config/coderv2/dotfiles
2024-07-09 12:05:07.209+03:00 Startup Script: Already up to date.
2024-07-09 12:05:07.648+03:00 Startup Script: Running install.sh...
2024-07-09 12:05:07.648+03:00 Startup Script: Dotfiles installation complete.
=== ✔ Running workspace agent startup scripts [11717ms]

@mafredri mafredri requested review from kylecarbs and mtojek July 9, 2024 10:33
@mafredri mafredri marked this pull request as ready for review July 9, 2024 10:33
@mafredri mafredri changed the title chore(cli): show information about --wait=no for ssh feat(cli): show information about --wait=no for ssh Jul 9, 2024
mtojek
mtojek approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mafredri mafredri merged commit ac6db5e into main Jul 9, 2024
34 checks passed
@mafredri mafredri deleted the mafredri/chore-cli-ssh-inform-user-about-wait branch July 9, 2024 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make coder ssh --wait=no more discoverable
2 participants
@mafredri @mtojek