Skip to content

feat(cli): pause notifications #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 11, 2024
Merged

feat(cli): pause notifications #13873

merged 13 commits into from
Jul 11, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 11, 2024

Fixes: coder/internal#4

This PR exposes extra CLI commands to manage notifications settings (pause/unpause). They require admin permissions to run.

@mtojek mtojek self-assigned this Jul 11, 2024
@mtojek mtojek changed the title feat(cli): pause notiifcations feat(cli): pause notifications Jul 11, 2024
@mtojek mtojek requested a review from dannykopping July 11, 2024 10:32
@mtojek mtojek marked this pull request as ready for review July 11, 2024 10:33
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits 👍

@mtojek mtojek merged commit bee913a into main Jul 11, 2024
29 checks passed
@mtojek mtojek deleted the 4-rest-pause branch July 11, 2024 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
}

for _, tt := range tests {
tt := tt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for the future: this is not necessary as of Go 1.22 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement REST API to pause/resume sending notifications, with CLI
2 participants