Skip to content

chore: patch 2.13.1 #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2024
Merged

chore: patch 2.13.1 #13927

merged 3 commits into from
Jul 18, 2024

Conversation

Parkreiner and others added 2 commits July 17, 2024 19:33
…es (#13761)

* fix: get basic fix in for  preventing download logs from blowing up UI

* fix: make sure blob units can't go out of bounds

* fix: make sure timeout is cleared on component unmount

* fix: reduce risk of shared cache state breaking useAgentLogs

* fix: allow partial downloading of logs

* fix: make sure useMemo cache is used properly

* wip: commit current progress on updated logs functionality

* docs: rewrite comment for clarity

* refactor: clean up current code

* fix: update styles for unavailable logs

* fix: resolve linter violations

* fix: update type signature of getErrorDetail

* fix: revert log/enabled logic for useAgentLogs

* fix: remove memoization from DownloadLogsDialog

* fix: update name of timeout state

* refactor: make log web sockets logic more clear

* docs: reword comment for clarity

* fix: commit current style update progress

* fix: finish style updates

(cherry picked from commit 940afa1)
@stirby stirby requested a review from sreya July 18, 2024 19:51
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize that we were getting rid of organization ID stuff to support multiple organizations, but it makes sense.

Everything looks good here.

@stirby stirby merged commit 5edfccf into release/2.13 Jul 18, 2024
28 checks passed
@stirby stirby deleted the patch/2.13.1 branch July 18, 2024 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@stirby stirby restored the patch/2.13.1 branch July 22, 2024 19:20
@stirby stirby deleted the patch/2.13.1 branch July 22, 2024 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants