Skip to content

docs: update caddy config example & guide #13964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2024
Merged

docs: update caddy config example & guide #13964

merged 4 commits into from
Jul 22, 2024

Conversation

nanospearing
Copy link
Contributor

The configuration that was shown as an example is incorrect. I have updated the information to reflect proper confs.

@nanospearing
Update README.md
369bc47 
The configuration that was shown as an example is incorrect. I have updated the information to reflect proper confs.
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jul 21, 2024
@nanospearing nanospearing changed the title fix(docs): Correct Caddy Wildcard Examples fix(docs): correct caddy wildcard examples Jul 21, 2024
@nanospearing
Copy link
Contributor Author

I feel like we should make a note about how you have to turn off the Cloudflare proxy in order to allow ssl to work properly for the port forwarding. I have also noticed that the on_demand_tls part also needs work since caddy now makes the user ask a endpoint to prevent abuse.

@nanospearing nanospearing changed the title fix(docs): correct caddy wildcard examples docs(Caddy): correct caddy wildcard examples Jul 21, 2024
@nanospearing nanospearing changed the title docs(Caddy): correct caddy wildcard examples docs(caddy): correct caddy wildcard examples Jul 21, 2024
@nanospearing nanospearing changed the title docs(caddy): correct caddy wildcard examples docs: correct caddy wildcard examples Jul 21, 2024
@nanospearing nanospearing marked this pull request as draft July 21, 2024 17:23
@nanospearing
docs: reflect the change in caddyfile
9bbd3f2 
I feel like someone will ignore this, but we better still add it...
@nanospearing nanospearing marked this pull request as ready for review July 21, 2024 17:30
@nanospearing
Copy link
Contributor Author

This document needs a lot more work, but this is good enough for now and is up to date.

@nanospearing nanospearing changed the title docs: correct caddy wildcard examples docs: update caddy config example Jul 21, 2024
@nanospearing nanospearing changed the title docs: update caddy config example docs: update caddy config example & guide Jul 21, 2024
@matifali matifali merged commit 40b70db into coder:main Jul 22, 2024
31 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@nanospearing nanospearing

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanospearing @kylecarbs @matifali