Skip to content

refactor: Add vertical space to the footer #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

refactor: Add vertical space to the footer #1410

merged 1 commit into from
May 12, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2022-05-12 at 14 09 56

After:
Screen Shot 2022-05-12 at 14 10 42

@BrunoQuaresma BrunoQuaresma self-assigned this May 12, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner May 12, 2022 17:13
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #1410 (73889da) into main (26b04cc) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
+ Coverage   67.29%   67.32%   +0.03%     
==========================================
  Files         288      288              
  Lines       19109    19109              
  Branches      241      241              
==========================================
+ Hits        12859    12865       +6     
+ Misses       4936     4931       -5     
+ Partials     1314     1313       -1
Flag Coverage Δ
unittest-go-macos-latest 54.50% <ø> (-0.07%) ⬇️
unittest-go-postgres- 65.87% <ø> (+0.10%) ⬆️
unittest-go-ubuntu-latest 56.72% <ø> (-0.06%) ⬇️
unittest-go-windows-2022 52.83% <ø> (+0.04%) ⬆️
unittest-js 74.19% <ø> (ø)
Impacted Files Coverage Δ
site/src/components/Footer/Footer.tsx 100.00% <ø> (ø)
site/src/pages/LoginPage/LoginPage.tsx 91.30% <ø> (ø)
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 65.90% <0.00%> (-1.24%) ⬇️
peer/conn.go 82.80% <0.00%> (+0.49%) ⬆️
provisionerd/provisionerd.go 77.51% <0.00%> (+0.53%) ⬆️
coderd/workspaceagents.go 57.90% <0.00%> (+1.86%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+2.40%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b04cc...73889da. Read the comment docs.

@BrunoQuaresma BrunoQuaresma merged commit a629a70 into main May 12, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-vertical-spacing-on-footer branch May 12, 2022 17:28
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
refactor: Add vertical space to the footer (#1410)
ca054c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @presleyp @misskniss