chore: Deploy internally accessible godoc container #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a preview URL? 👀 |
Codecov Report
@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 67.19% 67.14% -0.06%
==========================================
Files 287 287
Lines 19307 19307
Branches 241 241
==========================================
- Hits 12974 12964 -10
- Misses 4998 5006 +8
- Partials 1335 1337 +2
Continue to review full report at Codecov.
|
Sort of: https://internal-docs-c2oq3ixdcq-uc.a.run.app/pkg/github.com/coder/coder/ Unfortunately it's a bit clumsy to access at the moment. Based on the discussion in #1398 I haven't yet made the endpoint publicly accessible, so you have to pass a bearer token as described here. I used the ModHeader Chrome extension to test it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build a container image that runs
godocon our source code, and deploy it to Cloud Run for internal use.The Cloud Run/Build configurations are currently manually configured, but the important settings are:
/scripts/internal-docs/cloudbuild.yamlgcr.io/coder-devrel/internal-docsThe container uses https://github.com/dwahler/go-tools, which is a fork of golang.org/x/tools that doesn't serve traffic until it's finished scanning the repository, which is necessary to play nicely with Cloud Run's traffic balancing.
Fixes #1398