Skip to content

chore(scripts): remove branch checks from release script #14184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Aug 6, 2024

The initial assumption that branch manipulations should be done by this
script and not pushed to remote manually has proven to get in the way of
the regular release flow.

These are just safety-checks to prevent user error, safe to remove.

Fixes #13648

The initial assumption that branch manipulations should be done by this
script and not pushed to remote manually has proven to get in the way of
the regular release flow.

These are just safety-checks to prevent user error, safe to remove.
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mafredri mafredri requested a review from stirby August 6, 2024 14:46
@mafredri mafredri enabled auto-merge (squash) August 6, 2024 14:49
@mafredri mafredri disabled auto-merge August 6, 2024 14:49
@mafredri mafredri enabled auto-merge (squash) August 6, 2024 14:50
@mafredri mafredri merged commit 49feb12 into main Aug 6, 2024
35 checks passed
@mafredri mafredri deleted the mafredri/chore-scripts-remove-release-checks branch August 6, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release scripts: Remote ref check errors
1 participant