chore: add a unit test to ensure correct behaviour with multiple replicas and rename LifecycleTicker to AutobuildTicker #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
May 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
+ Coverage 58.80% 67.15% +8.35%
==========================================
Files 287 287
Lines 19331 19331
Branches 244 244
==========================================
+ Hits 11367 12982 +1615
+ Misses 6747 5007 -1740
- Partials 1217 1342 +125
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
May 13, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* chore: add a unit test to ensure correct behaviour with multiple coderd replicas * nit: rename LifecycleTicker to AutobuildTicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another unit test to
autobuild/executorto validate the correct behaviour when multiple coderd instances run in parallel.Note: this only works if you use a "real" database, as
coderdtest.Newby default uses a separate fake database instance per coderd.