chore: move back to single audit log page #14212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dec7da to
1c95f1a
Compare
|
🤖 Meticulous spotted visual differences in 254 of 1320 screens tested: view and approve differences detected. Last updated for commit 39defe5. This comment will update as new commits are pushed. |
b811cfc to
ba8db22
Compare
7d30eab to
95811ce
Compare
aslilac
approved these changes
Aug 7, 2024
e5e6e1c to
fdfe3ac
Compare
For now at least, we will have the one audit page at /audit which lets you filter by organization. This also removes the need to do per-org audit permission checks.
fdfe3ac to
39defe5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now at least, we will have the one audit page at /audit which lets you filter by organization.
This removes the need to do per-org audit permission checks on the sidebar.
I also filtered the audit log dropdown to only show orgs for which you can audit, since before it showed any orgs you could read. Selecting one of those orgs would give you "no audit logs" which is misleading.
Stacked on: