Skip to content

feat: filter templates by organization #14254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 14, 2024
Merged

feat: filter templates by organization #14254

merged 9 commits into from
Aug 14, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 12, 2024

Add support for filtering templates based on the organization they belong to.

As a bonus, since the backend already supports it, you can filter by deprecated and name as well.

Screenshot 2024-08-13 at 11 30 57 AM

@aslilac aslilac marked this pull request as draft August 12, 2024 23:22
Copy link

alwaysmeticulous bot commented Aug 13, 2024

🤖 Meticulous spotted visual differences in 67 of 1191 screens tested: view and approve differences detected.

Meticulous tested 104/112 of the executable lines edited in this PR1.

1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Last updated for commit 6a2fafd. This comment will update as new commits are pushed.

@aslilac aslilac marked this pull request as ready for review August 13, 2024 22:38
@jaaydenh

This comment was marked as resolved.

@jaaydenh

This comment was marked as resolved.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I'm missing tests for this feature.

Minor things that I found during QA:

  1. Should we display the count information at the top of the table, as we do for workspaces and other pages with filters?
Screenshot 2024-08-14 at 10 01 49
  1. I think we should only display the following content when it is empty, with no filters applied, or when there are no active templates.
Screenshot 2024-08-14 at 10 02 56

In my opinion, these are not blockers—perhaps the tests could be considered—but I'll trust your judgment, so I'm approving this. 👍

@aslilac
Copy link
Member Author

aslilac commented Aug 14, 2024

@BrunoQuaresma

  1. I'm going with no for now. This view isn't paginated, whereas the views that show this are. If we ever add pagination tho, definitely!

  2. Yeah, we should probably tweak this, but this feels good enough for the experiment. I'll make a note about revisiting it for GA.

@aslilac aslilac merged commit 8563b37 into main Aug 14, 2024
32 checks passed
@aslilac aslilac deleted the filter-templates-by-org branch August 14, 2024 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants