Skip to content

fix: always show upload and scratch in create template gallery #14327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 16, 2024

Now that multi-org is out of experimental, we should clean up some of the inconsistencies between the "orgs ui" and the "non-orgs ui". Along these lines, we should show the scratch and upload options in CreateTemplateGalleryPage even when the multi-organization experiment isn't enabled. They just live here now. :)

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 24, 2024
@github-actions github-actions bot closed this Aug 27, 2024
@aslilac
Copy link
Member Author

aslilac commented Aug 27, 2024

this will be merged eventually, just waiting for the right time (post multi-org ga)

@aslilac aslilac reopened this Aug 27, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Aug 28, 2024
@coder coder deleted a comment from alwaysmeticulous bot Sep 5, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 13, 2024
@aslilac
Copy link
Member Author

aslilac commented Sep 16, 2024

should be mergable in the next few weeks as we approach the end of the orgs experiment

@aslilac aslilac removed the stale This issue is like stale bread. label Sep 16, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 24, 2024
@aslilac aslilac removed the stale This issue is like stale bread. label Sep 26, 2024
@aslilac aslilac requested review from a team, code-asher, jaaydenh and Parkreiner and removed request for a team and code-asher September 30, 2024 16:17
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aslilac aslilac merged commit e70ad2b into main Sep 30, 2024
30 checks passed
@aslilac aslilac deleted the fix-create-template-gallery-page branch September 30, 2024 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants