chore: ui error handling should be specific to general #14346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific errors should be checked before defaulting to a general error handling
|
✅ Meticulous spotted zero visual differences across 1477 screens tested: view results. Meticulous tested 100% of the executable lines edited in this PR. Expected differences? Click here. Last updated for commit 1b39235. This comment will update as new commits are pushed. |
aslilac
reviewed
Aug 19, 2024
Added a story book 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific errors should be checked before defaulting to a general error handling.
I noticed the error details were not being shown in my manual testing. We should check for axios error before defaulting to a general string.