Skip to content

fix: include provisioner timing action in hash func #14388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

dannykopping
Copy link
Contributor

In timingSpan we use a hash function to efficiently lookup state transitions in a map.

I was not including the span action, which meant that if a resource was both deleted and created (a common approach with Terraform) then only one of those timings would be aggregated.

Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dannykopping dannykopping merged commit cc94420 into main Aug 22, 2024
28 checks passed
@dannykopping dannykopping deleted the dk/timings-hash-state branch August 22, 2024 10:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants