Skip to content

feat: notify about manual failed builds #14419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 27, 2024
Merged

feat: notify about manual failed builds #14419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
24e8c1b
Manual build failed
mtojek Aug 23, 2024
0782614
fix
mtojek Aug 23, 2024
2342d52
WIP
mtojek Aug 26, 2024
127aa47
simple test
mtojek Aug 26, 2024
e9737eb
fix
mtojek Aug 26, 2024
a13eb9e
Merge branch 'main' into 16-manual-build-failed
mtojek Aug 26, 2024
0d889b5
fix
mtojek Aug 26, 2024
015ec3c
double n
mtojek Aug 26, 2024
6a0b9f7
expose template version
mtojek Aug 26, 2024
f03cbc0
fix: logging
mtojek Aug 27, 2024
30f3809
build number
mtojek Aug 27, 2024
c2f038c
prepare
mtojek Aug 27, 2024
2381213
fmt
mtojek Aug 27, 2024
51b880c
fmt
mtojek Aug 27, 2024
e4f6f29
test
mtojek Aug 27, 2024
53f6eab
comment
mtojek Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build number
  • Loading branch information
@mtojek
mtojek committed Aug 27, 2024
commit 30f380910ddaa1cee465692c1b6da881f74b0cc5
4 changes: 2 additions & 2 deletions coderd/database/migrations/000248_notifications_manual_build_failed.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ VALUES ('2faeee0f-26cb-4e96-821c-85ccb9f71513', 'Workspace Manual Build Failed',
E'Hi {{.UserName}},\n\nA manual build of the workspace **{{.Labels.name}}** using the template **{{.Labels.template_name}}** failed (version: **{{.Labels.template_version_name}}**).\nThe workspace build was initiated by **{{.Labels.initiator}}**.',
'Workspace Events', '[
{
"label": "View workspace",
"url": "{{ base_url }}/@{{.Labels.workspace_owner_username}}/{{.Labels.name}}"
"label": "View build",
"url": "{{ base_url }}/@{{.Labels.workspace_owner_username}}/{{.Labels.name}}/builds/{{.Labels.workspace_build_number}}"
}
]'::jsonb);
1 change: 1 addition & 0 deletions coderd/notifications/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,7 @@ func TestNotificationTemplatesCanRender(t *testing.T) {
"template_version_name": "bobby-template-version",
"initiator": "joe",
"workspace_owner_username": "mrbobby",
"workspace_build_number": "3",
},
},
},
Expand Down
1 change: 1 addition & 0 deletions coderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,7 @@ func (s *server) notifyWorkspaceManualBuildFailed(ctx context.Context, workspace
"template_version_name": templateVersion.Name,
"initiator": build.InitiatorByUsername,
"workspace_owner_username": workspaceOwner.Username,
"workspace_build_number": strconv.Itoa(int(build.BuildNumber)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including this will mean that deduplication won't be possible, just so you're aware.

}, "provisionerdserver",
// Associate this notification with all the related entities.
workspace.ID, workspace.OwnerID, workspace.TemplateID, workspace.OrganizationID,
Expand Down
2 changes: 2 additions & 0 deletions coderd/provisionerdserver/provisionerdserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/json"
"io"
"net/url"
"strconv"
"strings"
"sync"
"sync/atomic"
Expand Down Expand Up @@ -1859,6 +1860,7 @@ func TestNotifications(t *testing.T) {
assert.Equal(t, version.Name, notifEnq.Sent[0].Labels["template_version_name"])
assert.Equal(t, user.Username, notifEnq.Sent[0].Labels["initiator"])
assert.Equal(t, user.Username, notifEnq.Sent[0].Labels["workspace_owner_username"])
assert.Equal(t, strconv.Itoa(int(build.BuildNumber)), notifEnq.Sent[0].Labels["workspace_build_number"])
})
}

Expand Down
Loading