chore: only show license expiry warning for deployment admins #14488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
50b9836 to
38a1f9a
Compare
This was referenced Aug 30, 2024
38a1f9a to
b6f8edf
Compare
36555a7 to
6287502
Compare
b6f8edf to
5545c0d
Compare
Emyrk
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13939.
The expiry notice is currently only shown to users with at least one role.
Since it's reasonable to have a role but not be considered a deployment admin, we'll only show the warning if the user has permission to read the deployment config.
Stacked as CI would not otherwise pass until #14489 is merged.