Skip to content

chore: disallow sdk imports from the db package #14539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2024
Merged

chore: disallow sdk imports from the db package #14539

merged 2 commits into from
Sep 3, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Sep 3, 2024

No description provided.

@Emyrk Emyrk marked this pull request as ready for review September 3, 2024 15:24
dannykopping
dannykopping approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emyrk Emyrk merged commit 7c8c027 into main Sep 3, 2024
27 checks passed
@Emyrk Emyrk deleted the stevenmasley/db_sdk_import branch September 3, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @dannykopping