Skip to content

chore: refactor entry into deployment and runtime #14575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 5, 2024
Merged

chore: refactor entry into deployment and runtime #14575

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e25a2f5
chore: refactor entry into deployment and runtime
Emyrk Sep 5, 2024
a47156d
refactor resolvers and managers
Emyrk Sep 5, 2024
9329805
chore: implement store manager
Emyrk Sep 5, 2024
0e280ca
remove dead code
Emyrk Sep 5, 2024
62fa3b0
remove comment
Emyrk Sep 5, 2024
f0ce1c4
fixups
Emyrk Sep 5, 2024
357438b
fixup authz test
Emyrk Sep 5, 2024
522cde1
Update coderd/runtimeconfig/manager.go
Emyrk Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@Emyrk
Emyrk committed Sep 5, 2024
commit 62fa3b005c2dd6467736fcf17a55e778bc34a267
6 changes: 0 additions & 6 deletions cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,12 +821,6 @@ func (r *RootCmd) Server(newAPI func(context.Context, *coderd.Options) (*coderd.
return err
}

// TODO: Throw a caching layer infront of the RuntimeConfig to prevent
// excessive database queries.
// Note: This happens before dbauthz, which is really unfortunate.
// dbauthz is configured in `Coderd.New()`, but we need the manager
// at this level for notifications. We might have to move some init
// code around.
options.RuntimeConfig = runtimeconfig.NewStoreManager()

// This should be output before the logs start streaming.
Expand Down
Loading