Skip to content

fix: correct default wsproxy table columns #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Oct 17, 2024

Closes #15123

It'd be nice if we could catch these table tags at compile time, but doesn't seem possible

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson changed the title fix: fix default wsproxy table columns fix: correct default wsproxy table columns Oct 17, 2024
@ethanndickson ethanndickson marked this pull request as ready for review October 17, 2024 12:53
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson enabled auto-merge (squash) October 17, 2024 12:56
@ethanndickson ethanndickson merged commit c81fd1d into main Oct 17, 2024
40 checks passed
@ethanndickson ethanndickson deleted the ethan/wsproxy-columns branch October 17, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: coder wsproxy edit throws error
1 participant