Skip to content

fix: show audit logs for forgot password flow #15181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 22, 2024
Merged

fix: show audit logs for forgot password flow #15181

merged 7 commits into from
Oct 22, 2024

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Oct 22, 2024 •
edited
Loading

Fixes #15150

Audit logs for requesting a password reset, and a user updating their password, now show up in the audit log.

Screenshot 2024-10-22 at 12 48 27

@DanielleMaywood DanielleMaywood marked this pull request as ready for review October 22, 2024 11:11
johnstcn
johnstcn approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The only potential quibble I have is the naming -- perhaps "password reset requested" would be more clear?

BrunoQuaresma
BrunoQuaresma approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@DanielleMaywood DanielleMaywood merged commit 5076161 into main Oct 22, 2024
31 of 33 checks passed
johnstcn
johnstcn approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DanielleMaywood DanielleMaywood deleted the dm-forgot-password-audit-logs branch October 22, 2024 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coderd/audit: ensure audit logs created for user password reset requests
3 participants
@DanielleMaywood @BrunoQuaresma @johnstcn