Skip to content

fix: show template name on workspace page when template display name is unset #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 29, 2024

Closes #15033

We usually show the name of a resource if its display_name is unset. We should give this breadcrumb popover on the workspace page the same treatment.

@aslilac aslilac requested review from a team and Kira-Pilot and removed request for a team October 29, 2024 00:33
@aslilac aslilac requested review from BrunoQuaresma and removed request for Kira-Pilot October 29, 2024 00:33
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think it would be good to have a test case for our breadcrumb component.

@aslilac
Copy link
Member Author

aslilac commented Oct 29, 2024

sure, I can add a test for this in storybook tomorrow

@aslilac aslilac merged commit bbd2dd8 into main Oct 29, 2024
27 checks passed
@aslilac aslilac deleted the lilac/show-template-name-on-workspace-page branch October 29, 2024 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the template name in Workspace details page
2 participants