Skip to content

feat: split management settings sidebar into deployment/organization sidebars #15388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 18, 2024
Merged

feat: split management settings sidebar into deployment/organization sidebars #15388

merged 19 commits into from
Dec 18, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Nov 5, 2024 •
edited
Loading

resolves coder/internal#199

Currently the admin settings has a combined sidebar for deployment settings and organization settings, this PR separates the sidebar in 2 sidebars for deployment and organization settings.

This is preparation for the redesign work of the organization settings sidebar where a dropdown will be user to select and create new organizations.

see figma: https://www.figma.com/design/OR75XeUI0Z3ksqt1mHsNQw/Dashboard-v1?node-id=684-5287&m=dev

This also does some of the initial redesign work for the sidebars using Tailwind.

Screenshot 2024-11-05 at 5 28 47 PM Screenshot 2024-11-05 at 5 28 56 PM

@jaaydenh jaaydenh self-assigned this Nov 5, 2024
@jaaydenh jaaydenh changed the title feat: split management settings sidebar into separate sidebars for deployment and organization settings feat: split management settings sidebar into deployment/organization sidebars Nov 5, 2024
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from 8cbb3ce to e6c163e Compare November 5, 2024 23:30
@jaaydenh jaaydenh force-pushed the tailwind-experiment branch from 302ca4f to 962045c Compare November 5, 2024 23:32
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from e6c163e to e7bf52f Compare November 5, 2024 23:33
Base automatically changed from tailwind-experiment to main November 6, 2024 17:53
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from 92a5056 to abec4cc Compare November 6, 2024 18:03
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 14, 2024
@github-actions github-actions bot closed this Nov 17, 2024
@jaaydenh jaaydenh reopened this Nov 17, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 18, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 26, 2024
@github-actions github-actions bot closed this Nov 30, 2024
@jaaydenh jaaydenh reopened this Nov 30, 2024
@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 1, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 9, 2024
@github-actions github-actions bot closed this Dec 13, 2024
@jaaydenh jaaydenh reopened this Dec 13, 2024
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from abec4cc to f2bf3cf Compare December 13, 2024 11:54
@jaaydenh jaaydenh removed the stale This issue is like stale bread. label Dec 13, 2024
@jaaydenh jaaydenh requested a review from aslilac December 13, 2024 18:07
@jaaydenh jaaydenh marked this pull request as ready for review December 13, 2024 18:08
@jaaydenh jaaydenh mentioned this pull request Dec 16, 2024
Merged
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from 5cb2fd3 to 1c6fe52 Compare December 17, 2024 11:22
@jaaydenh jaaydenh force-pushed the jaaydenh/settings-sidebar-split branch from 1c6fe52 to ac71d6c Compare December 17, 2024 18:32
aslilac
aslilac approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the organization settings sidebar looks a little weird without any padding on the left of the navigation items, since we haven't actually switched to the dropdown yet that's shown in the designs. Can we add a bit of padding back in the meantime?

@jaaydenh
Copy link
Contributor Author

The organizations dropdown should be completed in the next few days but temporarily adding indentation for the orgs sidebar items

@jaaydenh jaaydenh merged commit 8e61e4a into main Dec 18, 2024
29 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/settings-sidebar-split branch December 18, 2024 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@chrifro chrifro Awaiting requested review from chrifro

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

site: split admins settings sidebar into deployment and organization settings sidebars
2 participants
@jaaydenh @aslilac