feat: set DNS hostnames in workspace updates controller #15507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 14, 2024
002e484 to
e1ce08d
Compare
22526ba to
2803ed7
Compare
ethanndickson
approved these changes
Nov 14, 2024
e1ce08d to
08216aa
Compare
2803ed7 to
700a82f
Compare
700a82f to
0d7aa15
Compare
0d7aa15 to
1a3816c
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #14730
Adds support for the workspace updates protocol controller to also program DNS names for each agent.
Right now, we only program names like
myagent.myworkspace.me.coderandmyworkspace.coder.(if there is exactly one agent in the workspace). We also want to supportmyagent.myworkspace.username.coder., but for that we need to update WorkspaceUpdates RPC to also send the workspace owner's username, which will be in a separate PR.