fix: fix panic while tearing down reconnecting PTY #15615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05a33c0 to
6f45baf
Compare
johnstcn
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes coder/internal#221
Fixes an issue where two goroutines were sharing the
errvariable, leading to a data race where we'd fail to process the error and then nil-pointer panic.I ended up refactoring reconnecting PTY stuff into the
reconnectingptypackage, instead of having it on the agent. ThatcreateTailnetroutine had waaay too many deeply nested goroutines, which is I'm sure a big contributor to the bug appearing in the first place.