chore: improve validation of Security tag in swaggerparser #15660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Nov 26, 2024
|
Merging this one after CI - only |
Normally this step failing shouldn't be ignored, but since it's due to postgres' site being down (maybe they host on fly.io 🤔) it's fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #15605
There's currently one option valid for the
@Securitytag in swaggerparser - which fails in the CI if we try to put any other value.At least one of our endpoints does not accept
CoderSessionTokenas an option for the authentication and so we need to add new possibilities in order to keep the documentation up-to-date.In this PR , I added
ProvisionerKeywhich is the way our provisioner daemon can authenticate to the backend - also modified a bit the code to simplify other options later.