Skip to content

fix(examples/templates/aws-linux): add hashicorp/cloudinit provider #15794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(examples/templates/aws-linux): add hashicorp/cloudinit provider #15794

merged 1 commit into from
Dec 9, 2024

Conversation

phorcys420
Copy link
Member

No description provided.

@phorcys420 phorcys420 requested a review from matifali December 9, 2024 14:04
matifali
matifali approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be backported to release/2.18 too. Can you do that?

Also didn't we replace regions with the module?

@phorcys420
Copy link
Member Author

@matifali I thought we did but maybe only in aws-devcontainer?

It seems I didn't do it in #15500, i'll PR that soon.
for the backport, do you just want me to make another PR? not sure how that works

@matifali
Copy link
Member

matifali commented Dec 9, 2024

@phorcys420 Yes a PR to release/2.18 branch. as currently this template is broken in 2.18.

@phorcys420 phorcys420 enabled auto-merge (squash) December 9, 2024 14:31
@phorcys420 phorcys420 mentioned this pull request Dec 9, 2024
Merged
phorcys420 added a commit that referenced this pull request Dec 9, 2024
@phorcys420
fix(examples/templates/aws-linux): (backport) add hashicorp/cloudinit…
4097ec3 
… provider (#15796)

Backport #15794
@phorcys420
Copy link
Member Author

@matifali, I can't get required to turn green, do you think you can merge?

@matifali matifali disabled auto-merge December 9, 2024 16:39
@matifali matifali merged commit bc4f9a4 into main Dec 9, 2024
34 checks passed
@matifali matifali deleted the phorcys/fix-aws-linux-providers branch December 9, 2024 16:51
aslilac pushed a commit that referenced this pull request Dec 11, 2024
@phorcys420 @aslilac
fix(examples/templates/aws-linux): add hashicorp/cloudinit provider (…
336e83b 
…#15794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

Assignees

@phorcys420 phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phorcys420 @matifali