chore: migrate to coder/websocket 1.8.12 #15898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Should we update coder/tailscale at the same time so that we don't run two versions of websocket?
I did some testing against both coder/tailscale and coder/coder while working on coder/websocket#476 and didn't notice any glaring issues so stamping this PR (even though it does not include said fix).
75de15b to
e029dbb
Compare
|
ethanndickson
approved these changes
Dec 17, 2024
deansheather
approved these changes
Dec 18, 2024
e029dbb to
814d296
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates us to
coder/websocketv1.8.12 rather thannhooyr/websocketon an older version.Works around coder/websocket#504 by adding an explicit test for
xerrors.Is(err, io.EOF)where we were previously gettingio.EOFfrom the netConn.