feat: Add confirm prompts to some cli actions #1591
Conversation
Emyrk
commented
May 19, 2022
- Workspace start/stop
- Add optional -y skip. Standardize -y flag across commands
- Workspace start/stop - Add optional -y skip. Standardize -y flag across commands
|
I cannot figure out why Mac is failing 🤔 |
| // "yes" makes no sense. | ||
| if opts.IsConfirm && cmd.Flags().Lookup("yes") != nil { | ||
| if skip, _ := cmd.Flags().GetBool("yes"); skip { | ||
| return "yes", nil |
There was a problem hiding this comment.
Should we print to the terminal here e.g. Confirm create? (yes/no) yes, or Skipping: Confirm create? (yes/no) just to make it clear that the --yes flag had an effect?
There was a problem hiding this comment.
@mafredri I was unsure. Do other applications do this? apt-get does not have any indication for example.
For scripting purposes, I would imagine we want to reduce output to near 0 if we can.
I am not opposed to making it a global flag, would like to hear what others think. It's an easy change. |
* feat: Add confirm prompts to some cli actions - Add optional -y skip. Standardize -y flag across commands