Skip to content

chore(cli): skip scaletest tests when race detector enabled #16033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

chore(cli): skip scaletest tests when race detector enabled #16033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions cli/exp_scaletest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ import (
func TestScaleTestCreateWorkspaces(t *testing.T) {
t.Parallel()

if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

// This test only validates that the CLI command accepts known arguments.
// More thorough testing is done in scaletest/createworkspaces/run_test.go.
ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitLong)
Expand Down Expand Up @@ -65,6 +69,10 @@ func TestScaleTestCreateWorkspaces(t *testing.T) {
func TestScaleTestWorkspaceTraffic(t *testing.T) {
t.Parallel()

if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitMedium)
defer cancelFunc()

Expand Down Expand Up @@ -95,6 +103,10 @@ func TestScaleTestWorkspaceTraffic(t *testing.T) {
func TestScaleTestWorkspaceTraffic_Template(t *testing.T) {
t.Parallel()

if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitMedium)
defer cancelFunc()

Expand All @@ -120,6 +132,10 @@ func TestScaleTestWorkspaceTraffic_Template(t *testing.T) {
func TestScaleTestWorkspaceTraffic_TargetWorkspaces(t *testing.T) {
t.Parallel()

if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitMedium)
defer cancelFunc()

Expand All @@ -145,6 +161,10 @@ func TestScaleTestWorkspaceTraffic_TargetWorkspaces(t *testing.T) {
func TestScaleTestCleanup_Template(t *testing.T) {
t.Parallel()

if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitMedium)
defer cancelFunc()

Expand All @@ -169,6 +189,10 @@ func TestScaleTestCleanup_Template(t *testing.T) {
// This test just validates that the CLI command accepts its known arguments.
func TestScaleTestDashboard(t *testing.T) {
t.Parallel()
if testutil.RaceEnabled() {
t.Skip("Skipping due to race detector")
}

t.Run("MinWait", func(t *testing.T) {
t.Parallel()
ctx, cancelFunc := context.WithTimeout(context.Background(), testutil.WaitShort)
Expand Down
Loading