Skip to content

feat(site): connect open_in parameter #16036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 7, 2025
Merged

feat(site): connect open_in parameter #16036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4b115c
work on frontend connection with open_in
defelmnq Jan 3, 2025
224ee7a
work on frontend connection with open_in
defelmnq Jan 3, 2025
5824e5f
fix convert
defelmnq Jan 4, 2025
3597cec
fix convert
defelmnq Jan 4, 2025
3d89000
remove agent api unusued field
defelmnq Jan 7, 2025
fb07e8a
remove agent api unusued field
defelmnq Jan 7, 2025
f75f8c3
remove agent api unusued field
defelmnq Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove agent api unusued field
  • Loading branch information
@defelmnq
defelmnq committed Jan 7, 2025
commit fb07e8a790131a74e54976740a86f49b9b503ab8
1 change: 0 additions & 1 deletion agent/proto/agent.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ message WorkspaceApp {
AUTHENTICATED = 2;
PUBLIC = 3;
}

SharingLevel sharing_level = 10;

message Healthcheck {
Expand Down
1 change: 0 additions & 1 deletion codersdk/agentsdk/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ func ProtoFromApp(a codersdk.WorkspaceApp) (*proto.WorkspaceApp, error) {
if !ok {
return nil, xerrors.Errorf("unknown health %s", a.Health)
}

return &proto.WorkspaceApp{
Id: a.ID[:],
Url: a.URL,
Expand Down
Loading