Skip to content

docs: fix workspacebuilds logs api docs #16051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

coryb
Copy link
Contributor

@coryb coryb commented Jan 6, 2025

The before/after params were documented at Unix timestamps, but they are the log line ids.

The before/after params were documented at Unix timestamps, but they are
the log line ids.
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jan 6, 2025
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@matifali
Copy link
Member

matifali commented Jan 7, 2025

Hi @coryb you need to run make gen to make the CI pass. Thanks a lot for fixing this issue.

@EdwardAngert EdwardAngert self-assigned this Jan 7, 2025
@EdwardAngert EdwardAngert changed the base branch from main to 16051-timestamp-to-logid January 7, 2025 21:32
@EdwardAngert EdwardAngert merged commit a3b6e73 into coder:16051-timestamp-to-logid Jan 7, 2025
34 of 36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants