From 8b82e5d7d3265b3ae98f33abe046e78319cfe4db Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Wed, 8 Jan 2025 13:49:28 +0100 Subject: [PATCH 1/2] fix(site): do not error on closed build logs stream --- site/src/api/api.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/site/src/api/api.ts b/site/src/api/api.ts index 6b0e685b177eb..7673f0a7ba3bc 100644 --- a/site/src/api/api.ts +++ b/site/src/api/api.ts @@ -280,6 +280,9 @@ export const watchBuildLogsByBuildId = ( ); socket.addEventListener("error", () => { + if (socket.readyState == socket.CLOSED) { + return; + } onError?.(new Error("Connection for logs failed.")); socket.close(); }); From 8fd06241990d644587d3f19d0d09f028c25621c9 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Wed, 8 Jan 2025 13:58:39 +0100 Subject: [PATCH 2/2] fix lint --- site/src/api/api.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/api/api.ts b/site/src/api/api.ts index 7673f0a7ba3bc..f3a91f176ab88 100644 --- a/site/src/api/api.ts +++ b/site/src/api/api.ts @@ -280,7 +280,7 @@ export const watchBuildLogsByBuildId = ( ); socket.addEventListener("error", () => { - if (socket.readyState == socket.CLOSED) { + if (socket.readyState === socket.CLOSED) { return; } onError?.(new Error("Connection for logs failed."));