Skip to content

chore(testutil): add testutil.GoleakOptions #16070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore(testutil): add testutil.GoleakOptions #16070

merged 1 commit into from
Jan 8, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 8, 2025

@johnstcn johnstcn self-assigned this Jan 8, 2025
@johnstcn johnstcn requested review from dannykopping and Emyrk January 8, 2025 14:59
dannykopping
dannykopping approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic, thanks! 👍

Emyrk
Emyrk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a linter candidate 😄

@johnstcn johnstcn merged commit 7b88776 into main Jan 8, 2025
31 checks passed
@johnstcn johnstcn deleted the cj/testutil-goleakoptions branch January 8, 2025 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@Emyrk Emyrk Emyrk approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @dannykopping @Emyrk