Skip to content

fix: ensure active Organizations Page nav links are highlighted #16073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Jan 8, 2025

Normally the react router Navlink should normalize the url path and match with or without a / on the end of the path.

This is a fix to use useMatch() to explicitly see if the current path is a match to an href to determine whether to apply active styling to the navlink

@jaaydenh jaaydenh self-assigned this Jan 8, 2025
@jaaydenh jaaydenh marked this pull request as ready for review January 8, 2025 21:27
@jaaydenh jaaydenh requested a review from Parkreiner January 8, 2025 21:28
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Just had two small recommendations

@jaaydenh jaaydenh merged commit 630fd7c into main Jan 9, 2025
28 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/navlink-bug branch January 9, 2025 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@Parkreiner Parkreiner changed the title fix: navlink investigation fix: ensure active styling is applied consistently for Organizations page Jan 10, 2025
@Parkreiner Parkreiner changed the title fix: ensure active styling is applied consistently for Organizations page fix: ensure active Organizations Page nav links are highlighted Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants