Skip to content

fix: ensure active Deployment Page nav links are highlighted #16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: ensure active Deployment Page nav links are highlighted #16092

merged 1 commit into from
Jan 10, 2025

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Jan 10, 2025 •
edited
Loading

Addendum to #16073. We accidentally broke a few things with the change, and this make things right.

Changes made

  • Updated links in the deployment settings page to ensure that they're highlighted properly
  • Updated comment about previous PR to make sure it's clear why we were doing things a certain way.

Screenshots

(Look at the General link)

Before
Screenshot 2025-01-10 at 9 55 22 AM

After
Screenshot 2025-01-10 at 9 55 30 AM

@Parkreiner Parkreiner added the hotfix PRs only. Harmless small change. Only humans may set this. label Jan 10, 2025
@Parkreiner Parkreiner self-assigned this Jan 10, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Jan 10, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner changed the title fix: ensure active deployment nav links are highlighted fix: ensure active Deployment Page nav links are highlighted Jan 10, 2025
@Parkreiner
Copy link
Member Author

Parkreiner commented Jan 10, 2025 •
edited
Loading

@jaaydenh I'm making this a hotfix, but I'm tagging you so you're aware. We missed that the previous PR broke the Deployment page

The weird thing is that none of the changes here got detected as a diff in Storybook, so I'll try looking into that later today

@Parkreiner Parkreiner merged commit 8b9763d into main Jan 10, 2025
39 checks passed
@Parkreiner Parkreiner deleted the mes/deploy-links-fix branch January 10, 2025 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner