From e53b675702baa07fc0b5e510423376f8387bec69 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Mon, 13 Jan 2025 12:41:20 +0000 Subject: [PATCH 1/2] Only notify if required job fails Signed-off-by: Danny Kopping --- .github/workflows/ci.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 60717776a87eb..3b13656cf571f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1252,8 +1252,10 @@ jobs: make sqlc-vet notify-slack-on-failure: + needs: + - required runs-on: ubuntu-latest - if: always() && failure() && github.ref == 'refs/heads/main' + if: failure() && github.ref == 'refs/heads/main' steps: - name: Send Slack notification From d48290feaaf6901732f60cfb2f80b401e239b630 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Mon, 13 Jan 2025 13:02:29 +0000 Subject: [PATCH 2/2] Remove failing job name Signed-off-by: Danny Kopping --- .github/workflows/ci.yaml | 4 ---- .github/workflows/nightly-gauntlet.yaml | 4 ---- 2 files changed, 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3b13656cf571f..df752d2aa41f0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1278,10 +1278,6 @@ jobs: "type": "mrkdwn", "text": "*Workflow:*\n${{ github.workflow }}" }, - { - "type": "mrkdwn", - "text": "*Failed Job:*\n${{ github.job }}" - }, { "type": "mrkdwn", "text": "*Committer:*\n${{ github.actor }}" diff --git a/.github/workflows/nightly-gauntlet.yaml b/.github/workflows/nightly-gauntlet.yaml index c76eba484bfde..5814ddf72b60f 100644 --- a/.github/workflows/nightly-gauntlet.yaml +++ b/.github/workflows/nightly-gauntlet.yaml @@ -101,10 +101,6 @@ jobs: "type": "mrkdwn", "text": "*Workflow:*\n${{ github.workflow }}" }, - { - "type": "mrkdwn", - "text": "*Failed Job:*\n${{ github.job }}" - }, { "type": "mrkdwn", "text": "*Committer:*\n${{ github.actor }}"