Skip to content

fix: return only the first workspace agent script timing per script #16203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

DanielleMaywood
Copy link
Contributor

Fixes #16124

If a workspace agent crashes, it is possible for any startup scripts to be ran again. This PR makes it so that the GetWorkspaceAgentScriptTimingsByBuildID query only returns the first timing recorded per-script.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review January 21, 2025 11:23
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DanielleMaywood DanielleMaywood merged commit 5762d8a into main Jan 21, 2025
34 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-do-not-return-second-script-timing-run branch January 21, 2025 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
@matifali
Copy link
Member

/cherry-pick release/2.18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Agent script timings are returning more than one script timing for script
3 participants