Skip to content

fix: return first workspace agent script timing per script (cherry-pick #16203) #16208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: return first workspace agent script timing per script (cherry-pick #16203) #16208

merged 1 commit into from
Jan 21, 2025

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: return only the first workspace agent script timing per script (#16203)

Fixes #16124

If a workspace agent crashes, it is possible for any startup scripts to
be ran again. This PR makes it so that the
GetWorkspaceAgentScriptTimingsByBuildID query only returns the first
timing recorded per-script.

@DanielleMaywood
fix: return only the first workspace agent script timing per script (#…
b904d0c 
…16203)

Fixes #16124

If a workspace agent crashes, it is possible for any startup scripts to
be ran again. This PR makes it so that the
`GetWorkspaceAgentScriptTimingsByBuildID` query only returns the first
timing recorded per-script.
@matifali
Copy link
Member

cc: @BrunoQuaresma @stirby

@matifali matifali changed the title fix: return only the first workspace agent script timing per script (cherry-pick #16203) fix: return first workspace agent script timing per script (cherry-pick #16203) Jan 21, 2025
DanielleMaywood
DanielleMaywood approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@matifali matifali requested a review from stirby January 21, 2025 14:51
@matifali matifali merged commit bd6f426 into release/2.18 Jan 21, 2025
31 checks passed
@matifali matifali deleted the cherry-pick-5a3e03-release/2.18 branch January 21, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

@stirby stirby Awaiting requested review from stirby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @DanielleMaywood