feat(cli): support deleting tokens by id #16341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aee1553 to
1a092c4
Compare
deansheather
reviewed
Feb 3, 2025
1a092c4 to
2949164
Compare
c11fd15 to
ec8ff1a
Compare
deansheather
approved these changes
Feb 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since API keys can be created without a name, and we already perform the deletion by ID, it makes sense to be able to delete tokens with just the ID.
Although it requires an API change, it would be nice if
coder tokens listalso listed other token types. Currently it only lists tokens ofloginTypeToken. CLI tokens generated on/cli-authareloginTypePassword, and as such do not show up.