Skip to content

feat: add terminal links #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2022
Merged

feat: add terminal links #1636

merged 2 commits into from
May 23, 2022

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 20, 2022 •
edited
Loading

terminal-links

Closes #760

@code-asher code-asher force-pushed the code-asher/terminal-links branch from 37f04bd to afa679a Compare May 20, 2022 19:28
@code-asher code-asher marked this pull request as ready for review May 20, 2022 19:44
@code-asher code-asher requested a review from a team as a code owner May 20, 2022 19:44
@code-asher
Copy link
Member Author

code-asher commented May 20, 2022 •
edited
Loading

It occurs to me that maybe I should only show the link if the status is "connected"?

@greyscaled
Copy link
Contributor

It occurs to me that maybe I should only show the link if the status is "connected"?

fair enough

@ammario
Copy link
Member

ammario commented May 21, 2022 •
edited
Loading

Why not make it a button 😬?

Also, I think it could be shortened "Open Terminal" or even just "Terminal".

@ammario
Copy link
Member

ammario commented May 23, 2022

Also resolves #265

@code-asher code-asher force-pushed the code-asher/terminal-links branch from 55081d5 to d59d94d Compare May 23, 2022 20:31
@code-asher
Copy link
Member Author

code-asher commented May 23, 2022 •
edited
Loading

Button and text change seems chill to me, gonna add a note on #1648

@code-asher code-asher force-pushed the code-asher/terminal-links branch from d59d94d to 8a31fe9 Compare May 23, 2022 20:34
@code-asher code-asher merged commit dd4bb07 into main May 23, 2022
@code-asher code-asher deleted the code-asher/terminal-links branch May 23, 2022 20:49
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@code-asher @kylecarbs
feat: add terminal links (#1636)
f17a22d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the web terminal to the workspaces Application card
4 participants
@code-asher @greyscaled @ammario @Kira-Pilot