Skip to content

chore(agent/agentcontainers): skip TestDockerCLIContainerLister by default #16502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

chore(agent/agentcontainers): skip TestDockerCLIContainerLister by default #16502

merged 2 commits into from
Feb 10, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 10, 2025 •
edited
Loading

Addresses a test flake seen here: https://github.com/coder/coder/actions/runs/13239819615/job/36952521742

Also addresses the case where we would try to run docker inspect with no container IDs, which is a silly thing to do.

@johnstcn johnstcn added the hotfix PRs only. Harmless small change. Only humans may set this. label Feb 10, 2025
@johnstcn johnstcn self-assigned this Feb 10, 2025
cdr-bot[bot]
cdr-bot bot approved these changes Feb 10, 2025
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 140f2a9 into main Feb 10, 2025
30 checks passed
@johnstcn johnstcn deleted the cj/agentcontainers/skip-docker-by-default branch February 10, 2025 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@johnstcn johnstcn

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn