From 53e92ca1bd30c50ebbc633f3f7d95b99c231c91a Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Tue, 11 Feb 2025 18:43:32 +0000 Subject: [PATCH] chore(cli): disable agent devcontainer integration by default --- cli/agent.go | 2 +- cli/testdata/coder_agent_--help.golden | 2 +- dogfood/contents/main.tf | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cli/agent.go b/cli/agent.go index f87959aec1c49..e8a46a84e071c 100644 --- a/cli/agent.go +++ b/cli/agent.go @@ -475,7 +475,7 @@ func (r *RootCmd) workspaceAgent() *serpent.Command { }, { Flag: "devcontainers-enable", - Default: "true", + Default: "false", Env: "CODER_AGENT_DEVCONTAINERS_ENABLE", Description: "Allow the agent to automatically detect running devcontainers.", Value: serpent.BoolOf(&devcontainersEnabled), diff --git a/cli/testdata/coder_agent_--help.golden b/cli/testdata/coder_agent_--help.golden index 3dcbb343149d3..6548a2fadbe49 100644 --- a/cli/testdata/coder_agent_--help.golden +++ b/cli/testdata/coder_agent_--help.golden @@ -33,7 +33,7 @@ OPTIONS: --debug-address string, $CODER_AGENT_DEBUG_ADDRESS (default: 127.0.0.1:2113) The bind address to serve a debug HTTP server. - --devcontainers-enable bool, $CODER_AGENT_DEVCONTAINERS_ENABLE (default: true) + --devcontainers-enable bool, $CODER_AGENT_DEVCONTAINERS_ENABLE (default: false) Allow the agent to automatically detect running devcontainers. --log-dir string, $CODER_AGENT_LOG_DIR (default: /tmp) diff --git a/dogfood/contents/main.tf b/dogfood/contents/main.tf index 34adf3dcc6fde..ecd0925c490e4 100644 --- a/dogfood/contents/main.tf +++ b/dogfood/contents/main.tf @@ -374,6 +374,7 @@ resource "docker_container" "workspace" { "CODER_PROC_PRIO_MGMT=1", "CODER_PROC_OOM_SCORE=10", "CODER_PROC_NICE_SCORE=1", + "CODER_AGENT_DEVCONTAINERS_ENABLE=1", ] host { host = "host.docker.internal"