Skip to content

docs: add oom/ood to notifications #16582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 5, 2025
Merged

docs: add oom/ood to notifications #16582

merged 6 commits into from
Mar 5, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Feb 14, 2025

  • add section or to another section: where the notifications show up/how to access

previews:

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Feb 14, 2025
@EdwardAngert EdwardAngert marked this pull request as ready for review February 18, 2025 20:50
@EdwardAngert
Copy link
Contributor Author

  • BP terraform code for a template should be in templates; notifications page should link to extending templates > resource monitoring {new} | terraform code goes there (as explaining resources_monitoring)

@EdwardAngert
Copy link
Contributor Author

@defelmnq @stirby after talking with @bpmct about where this fits in, I put the tf block in a new resource monitoring page

I'd also like to add a Resource monitoring section that introduces it in Extending templates - I don't think it's a blocker for this PR, but I want people to be able to find it

Copy link
Contributor

@defelmnq defelmnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM

Just a question - should we precise that the alerts are sent through SMTP ? (Means the deployment needs to have SMTP configured.)

Comment on lines 15 to 18
## Prerequisites

Notifications are sent through SMTP.
Configure Coder to [use an SMTP server](../../monitoring/notifications.md#smtp-email).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@defelmnq definitely yes to letting them know it's through SMTP - how does this seem?

@github-actions github-actions bot added the stale This issue is like stale bread. label Mar 4, 2025
@matifali matifali requested a review from defelmnq March 4, 2025 17:22
@github-actions github-actions bot removed the stale This issue is like stale bread. label Mar 5, 2025
@matifali matifali merged commit 9251e0d into main Mar 5, 2025
28 checks passed
@matifali matifali deleted the 16581-oom-ood-notif branch March 5, 2025 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants