Skip to content

fix: require permissions to view pages related to organization roles #16688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: require permissions to view pages related to organization roles #16688

merged 1 commit into from
Feb 25, 2025

Conversation

brettkolodny
Copy link
Contributor

@brettkolodny brettkolodny commented Feb 24, 2025 •
edited
Loading

Closes this issue

This PR adds the<RequirePermissions /> component to the following routes:

  • /organizations/<org>/roles
  • /organizations/<org>/roles/create

@brettkolodny brettkolodny marked this pull request as ready for review February 25, 2025 13:59
jaaydenh
jaaydenh approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brettkolodny brettkolodny merged commit 33c9aa0 into main Feb 25, 2025
38 checks passed
@brettkolodny brettkolodny deleted the brett/a-user-without-permissions-to-create-a-custom-role-can-acces branch February 25, 2025 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes

Assignees

@brettkolodny brettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A user without permissions to create a custom role can access this page by the url
2 participants
@brettkolodny @jaaydenh