From 63a33f9ee6f20dcb961fda3a5894880b63402854 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Thu, 27 Feb 2025 14:04:23 +0100 Subject: [PATCH 1/2] fix: handle undefined job while updating build progress --- site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx b/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx index 88f006681495e..9ab0a634c6e4c 100644 --- a/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx @@ -81,6 +81,7 @@ export const WorkspaceBuildProgress: FC = ({ useEffect(() => { const updateProgress = () => { if ( + job == undefined || job.status !== "running" || transitionStats.P50 === undefined || transitionStats.P95 === undefined || From e04d94b83f1891495fcda69204e2a225df627078 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Thu, 27 Feb 2025 14:16:52 +0100 Subject: [PATCH 2/2] lint --- site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx b/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx index 9ab0a634c6e4c..52f3e725c6003 100644 --- a/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceBuildProgress.tsx @@ -81,7 +81,7 @@ export const WorkspaceBuildProgress: FC = ({ useEffect(() => { const updateProgress = () => { if ( - job == undefined || + job === undefined || job.status !== "running" || transitionStats.P50 === undefined || transitionStats.P95 === undefined ||