chore: perform several small frontend permissions refactors #16735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d9ec85 to
e98ccd3
Compare
BrunoQuaresma
approved these changes
Mar 6, 2025
| }); | ||
|
|
||
| async function resetSearch(page: Page) { | ||
| async function resetSearch(page: Page, username: string) { |
There was a problem hiding this comment.
Nit: I think a better name for this function could be filterByUser or searchByUser.
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/LicenseSeatConsumptionChart.tsx
Show resolved
Hide resolved
jaaydenh
reviewed
Mar 6, 2025
fe9bbea to
ee5013f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small changes that I made while fixing bugs and cleaning up permissions code, but that couldn't get merged as part of the bigger PR out of risk of creating too much noise when cherry picking to the release branches.