Skip to content

feat: include winres metadata in Windows binaries (cherry-pick #16706) #16742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2025
Merged

feat: include winres metadata in Windows binaries (cherry-pick #16706) #16742

merged 6 commits into from
Feb 28, 2025
+185 −21

Conversation

matifali
Copy link
Member

@matifali matifali commented Feb 28, 2025 •
edited
Loading

cherry picks #16706 to release/2.20

@deansheather
feat: include winres metadata in Windows binaries
85e2a6a 
Adds information like product/file version, description, product name
and copyright to compiled Windows binaries in dogfood and release
builds.
@deansheather
test CI
d2c54b3
@deansheather
fix: add permission for gcloud auth
cf9fc04
@deansheather
test CI 2
970bf8a
@deansheather
Revert "test CI 2"
35dc760 
This reverts commit 970bf8a.
@deansheather
Revert "test CI"
5d9c439 
This reverts commit d2c54b3.
@matifali matifali requested a review from stirby February 28, 2025 07:28
@matifali matifali merged commit 36186bb into release/2.20 Feb 28, 2025
76 checks passed
@matifali matifali deleted the dean/winres branch February 28, 2025 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@stirby stirby Awaiting requested review from stirby

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @deansheather