chore: add custom samesite options to auth cookies #16885
Merged
+240
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3c3687 to
096187a
Compare
399f8a3 to
7542e5a
Compare
Advanced feature, not recommended to use
11bb888 to
90758f5
Compare
aslilac
approved these changes
Apr 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows controlling
samesitecookie settings.This has been reported to be required to get embedding Coder app into an iframe to work. The use case has coder on
coder.domain.comand the external app onapp.coder.comwith path based apps.This PR was verified to resolve the issue. This option is configurable via a deployment flag option.
External fork: Labelbox@8737520