Skip to content

feat(coderd): add inbox notifications endpoints #16889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 17, 2025
Merged

feat(coderd): add inbox notifications endpoints #16889

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3c6512b
add endpoints for inbox notifications
defelmnq Mar 12, 2025
c8ccc60
cleanup comments and errors
defelmnq Mar 12, 2025
18b694b
skip tests on windows
defelmnq Mar 12, 2025
0e8ac4c
work on pr comments - cleanup endpoints and isolate logic
defelmnq Mar 13, 2025
d72d1f2
work on PR comments
defelmnq Mar 13, 2025
796bcd0
fix parameters validation
defelmnq Mar 13, 2025
75c310d
improve parameters validation
defelmnq Mar 13, 2025
07ab7c4
fmt and lint
defelmnq Mar 13, 2025
cb41d1a
websocket testing wip
defelmnq Mar 14, 2025
6ff4c7e
improve tests
defelmnq Mar 14, 2025
1ebc7f4
make fmt and lint
defelmnq Mar 14, 2025
736a2d7
make fmt and lint
defelmnq Mar 14, 2025
c28002e
remove windows from watch handler tests
defelmnq Mar 17, 2025
2637d86
fix comments
defelmnq Mar 17, 2025
4d0a561
fix tests
defelmnq Mar 17, 2025
1f18868
fix ci lint
defelmnq Mar 17, 2025
4f01a86
fix ci lint
defelmnq Mar 17, 2025
cf6af1b
fix ci lint
defelmnq Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip tests on windows
  • Loading branch information
@defelmnq
defelmnq committed Mar 12, 2025
commit 18b694bf0298f5ca38f7924cbae1f7eefaf5dcff
21 changes: 14 additions & 7 deletions coderd/inboxnotifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ import (
func TestInboxNotifications_List(t *testing.T) {
t.Parallel()

// I skip these tests specifically on windows as for now they are flaky - only on Windows.
// For now the idea is that the runner takes too long to insert the entries, could be worth
// investigating a manual Tx.
if runtime.GOOS == "windows" {
t.Skip("our runners are randomly taking too long to insert entries")
}

t.Run("OK empty", func(t *testing.T) {
t.Parallel()

Expand All @@ -42,13 +49,6 @@ func TestInboxNotifications_List(t *testing.T) {
t.Run("OK with pagination", func(t *testing.T) {
t.Parallel()

// I skip these tests specifically on windows as for now they are flaky - only on Windows.
// For now the idea is that the runner takes too long to insert the entries, could be worth
// investigating a manual Tx.
if runtime.GOOS == "windows" {
t.Skip("our runners are randomly taking too long to insert entries")
}

client, _, api := coderdtest.NewWithAPI(t, &coderdtest.Options{})
firstUser := coderdtest.CreateFirstUser(t, client)

Expand Down Expand Up @@ -257,6 +257,13 @@ func TestInboxNotifications_List(t *testing.T) {
func TestInboxNotifications_ReadStatus(t *testing.T) {
t.Parallel()

// I skip these tests specifically on windows as for now they are flaky - only on Windows.
// For now the idea is that the runner takes too long to insert the entries, could be worth
// investigating a manual Tx.
if runtime.GOOS == "windows" {
t.Skip("our runners are randomly taking too long to insert entries")
}

client, _, api := coderdtest.NewWithAPI(t, &coderdtest.Options{})
firstUser := coderdtest.CreateFirstUser(t, client)

Expand Down
Loading